Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark Dataset runner] Prevent stackoverflow in ParDo load tests #25732

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

mosche
Copy link
Member

@mosche mosche commented Mar 6, 2023

Prevent Stackoverflow in ParDo load tests when using RDDs to break linage for large number of consecutive ParDos.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

… using RDDs to break linage for large number of consequtive ParDos
@mosche
Copy link
Member Author

mosche commented Mar 6, 2023

Run Load Tests Java ParDo SparkStructuredStreaming Batch

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@mosche
Copy link
Member Author

mosche commented Mar 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche mosche merged commit 9b6b72f into apache:master Mar 6, 2023
@mosche mosche deleted the spark_ds_fix_pardo_loadtest branch March 6, 2023 12:56
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
… using RDDs to break linage for large number of consequtive ParDos (apache#25732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants