Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark Dataset runner] Avoid copying outputs for most cases in ParDo translation #25624

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

mosche
Copy link
Member

@mosche mosche commented Feb 24, 2023

A minor improvement following up on #24711.
This avoids copying outputs for most cases (when removing obsolete, unconsumed outputs) in ParDo translation.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@mosche mosche marked this pull request as ready for review February 24, 2023 14:39
@mosche
Copy link
Member Author

mosche commented Feb 24, 2023

R: @aromanenko-dev
R: @echauchot
A small improvement for the DS runner

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@echauchot echauchot self-requested a review March 3, 2023 15:06
@echauchot
Copy link
Contributor

@mosche thanks. Will take a look on Monday

@echauchot
Copy link
Contributor

Run Spark StructuredStreaming ValidatesRunner

Copy link
Contributor

@echauchot echauchot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Merging

@echauchot echauchot merged commit 5a2b93d into apache:master Mar 6, 2023
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
@mosche mosche deleted the 24710_copy_less branch May 11, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants