Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate removal of RDD caching for MEMORY_ONLY in the Spark Dataset runner #25327

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

mosche
Copy link
Member

@mosche mosche commented Feb 6, 2023

A small simplification ... removing RDD caching for the Spark Dataset runner.

With the recent RDD linage fix (#25187) there's no visible improvement that justifies the added complexity. Moreover, the recommended storage level with Spark Datasets is MEMORY_AND_DISK (rather than MEMORY_ONLY). This makes RDD caching fairly irrelevant for production use cases with the Dataset runner.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Spark Runner Nexmark Tests

1 similar comment
@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Spark Runner Nexmark Tests

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Spark Runner Tpcds Tests

9 similar comments
@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 8, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 8, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 22, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 22, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 23, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 23, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 23, 2023

Run Java PreCommit

@mosche
Copy link
Member Author

mosche commented Feb 23, 2023

Run Spark Runner Tpcds Tests

3 similar comments
@mosche
Copy link
Member Author

mosche commented Feb 23, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 24, 2023

Run Spark Runner Tpcds Tests

@mosche
Copy link
Member Author

mosche commented Feb 24, 2023

Run Spark Runner Tpcds Tests

@mosche mosche force-pushed the spark_ds_no_rdd_persist branch from b941b13 to 52fdd58 Compare February 24, 2023 14:22
@mosche mosche marked this pull request as ready for review February 24, 2023 15:33
@mosche
Copy link
Member Author

mosche commented Feb 24, 2023

Run Spark StructuredStreaming ValidatesRunner

@mosche
Copy link
Member Author

mosche commented Feb 24, 2023

R: @echauchot
R: @aromanenko-dev

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@echauchot
Copy link
Contributor

@mosche need to finish something, I'll take a look tomorrow or wednesday

@echauchot
Copy link
Contributor

 @mosche reviewing ...

Copy link
Contributor

@echauchot echauchot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Moritz ! Merging

@echauchot echauchot merged commit f49b450 into apache:master Mar 3, 2023
@mosche mosche deleted the spark_ds_no_rdd_persist branch March 3, 2023 14:37
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants