-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate removal of RDD caching for MEMORY_ONLY in the Spark Dataset runner #25327
Conversation
Run Spark Runner Tpcds Tests |
Run Spark Runner Nexmark Tests |
1 similar comment
Run Spark Runner Nexmark Tests |
Run Spark Runner Tpcds Tests |
9 similar comments
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Java PreCommit |
Run Spark Runner Tpcds Tests |
3 similar comments
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
Run Spark Runner Tpcds Tests |
b941b13
to
52fdd58
Compare
Run Spark StructuredStreaming ValidatesRunner |
R: @echauchot |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
@mosche need to finish something, I'll take a look tomorrow or wednesday |
@mosche reviewing ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Moritz ! Merging
A small simplification ... removing RDD caching for the Spark Dataset runner.
With the recent RDD linage fix (#25187) there's no visible improvement that justifies the added complexity. Moreover, the recommended storage level with Spark Datasets is MEMORY_AND_DISK (rather than MEMORY_ONLY). This makes RDD caching fairly irrelevant for production use cases with the Dataset runner.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.