Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark runner] Removal of Spark 2 runner support #25263

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

mosche
Copy link
Member

@mosche mosche commented Feb 1, 2023

The runner for Spark 2 was deprecated quite a while back in August 2022 with the release of Beam 2.41.0.

This PR finally removes support for Spark 2 (beam-runners-spark) to only maintain support for Spark 3 (beam-runners-spark-3) going forward.

Closes #25259


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@mosche
Copy link
Member Author

mosche commented Feb 1, 2023

R: @aromanenko-dev

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #25263 (86d464b) into master (88da381) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #25263   +/-   ##
=======================================
  Coverage   72.95%   72.95%           
=======================================
  Files         745      745           
  Lines       99191    99191           
=======================================
+ Hits        72361    72369    +8     
+ Misses      25465    25456    -9     
- Partials     1365     1366    +1     
Flag Coverage Δ
python 82.46% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dks/python/apache_beam/options/pipeline_options.py 93.97% <ø> (ø)
...on/apache_beam/runners/portability/spark_runner.py 67.34% <0.00%> (ø)
...m/runners/portability/spark_uber_jar_job_server.py 84.32% <0.00%> (ø)
sdks/go/pkg/beam/core/metrics/dumper.go 49.20% <0.00%> (-4.77%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 81.88% <0.00%> (+0.14%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (+0.16%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.61% <0.00%> (+0.36%) ⬆️
...eam/runners/portability/fn_api_runner/execution.py 93.13% <0.00%> (+0.63%) ⬆️
...python/apache_beam/runners/worker/worker_status.py 75.33% <0.00%> (+0.66%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mosche mosche force-pushed the 25259_remove_spark_2 branch from 2ef241c to 1e76728 Compare February 3, 2023 07:27
@mosche
Copy link
Member Author

mosche commented Feb 3, 2023

R: @je-ik
R: @JozoVilcek

@mosche
Copy link
Member Author

mosche commented Feb 3, 2023

Run Python_Runners PreCommit

1 similar comment
@mosche
Copy link
Member Author

mosche commented Feb 3, 2023

Run Python_Runners PreCommit

@mosche
Copy link
Member Author

mosche commented Feb 3, 2023

Run Java_Pulsar_IO_Direct PreCommit

Copy link
Contributor

@JozoVilcek JozoVilcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mosche , LGTM

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

@aromanenko-dev Could you have a look, pls. Any objections moving ahead with the removal?

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, just several minor questions, ptal

Before merging, please, run all related pre- and post- commit jobs to make sure that nothing is broken.

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Python Spark ValidatesRunner

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Java PostCommit

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run SQL PostCommit

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Run Go PostCommit

@mosche
Copy link
Member Author

mosche commented Feb 6, 2023

Before merging, please, run all related pre- and post- commit jobs to make sure that nothing is broken.

@aromanenko-dev This pretty much triggered all pre jobs automatically in addition to the post jobs run above. Anything else you have in mind?

@aromanenko-dev
Copy link
Contributor

@mosche Nope, I think it should be enough

@aromanenko-dev
Copy link
Contributor

@mosche Could you rebase a feature branch against master instead of merging?

@mosche
Copy link
Member Author

mosche commented Feb 8, 2023

@aromanenko-dev That's what github does if resolving a conflict in the UI. It absolutely doesn't make a difference if squashed before merging.

@mosche
Copy link
Member Author

mosche commented Feb 8, 2023

Run Java_Kafka_IO_Direct PreCommit

@mosche mosche merged commit 063eea6 into apache:master Feb 8, 2023
@mosche mosche deleted the 25259_remove_spark_2 branch February 8, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Planned removal of Spark 2 runner support
3 participants