Add ability to configure ArtifactService gRPC Channel

[snallapa]

The purpose of this PR is to support configurable gRPC channels for ArtifactService. We have use cases where we run the ExpansionService in different environments. One example environment is in Google Cloud Run. This requires authenticated gRPC calls with the google cloud token in the gRPC header and transport security enabled vs plaint text. With the current public methods, we can do this for the expand stub with no problem, but not for the artifact stub which would need the same channel configuration. We ended up monkey patching this to get our use case to work. I am contributing the monkey patch back to beam.

address #25840

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[chamikaramj]

Thanks. Looks good in general.

Can you add a unit test ?

[chamikaramj]

Also, please attach a Github issue.

[snallapa]

@chamikaramj sounds good ill add one later today, or tomorrow

[snallapa]

@chamikaramj sorry for the late update, went on vacation. Here is the issue ill include it in the PR description as well. I will update this branch with testing now as well.

[chamikaramj]

BTW, how would you use this ?
I don't see a good way to override the DefaultExpansionServiceClientFactory in our API currently.

If there's a way to override this you could setup an integration test that provides required dependencies through a custom ArtifactService.

[snallapa]

@chamikaramj you would have to use the External.of constructor with a new implementation ExpansionServiceClientFactory (the one that is visible for testing but it is public)

I can try that, do you have an example?

[chamikaramj]

Hmm, I don't think that "visible for testing" API is intended for production use-cases. How about updating the default client factory to support secure gRPC channels. I think that's a change we should do anyways.

Regarding testing, we have a number of Java cross-language tests running so may be you can add to that.
https://ci-beam.apache.org/job/beam_PostCommit_XVR_JavaUsingPython_Dataflow/1644/testReport/

[snallapa]

@chamikaramj thank you, I will update and try that soon!

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[github-actions]

Reminder, please take a look at this pr: @robertwb

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @robertwb

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @robertwb

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @robertwb

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @robertwb

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @robertwb

[tvalentyn]

waiting on author

[github-actions]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[snallapa]

no time for this sorry, if anyone else is interested they can pick it up 👍