[#24266] Update release candidate script to use -PisRelease #24269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
lukecwik
added a commit
to lukecwik/incubator-beam-site
that referenced
this pull request
Nov 18, 2022
…ion.
Ran `find ./ -type f -exec sed -i 's/-SNAPSHOT//g' {} \;` to search and remove -SNAPSHOT
This is to apply apache/beam#24269 to previous documentation releases for apache/beam#24266
Note that this adds additional tasks which in the past have caused failures which is why we add --no-daemon and --no-parallel Fixes apache#24266
Codecov Report
@@ Coverage Diff @@
## master #24269 +/- ##
==========================================
- Coverage 73.46% 73.45% -0.01%
==========================================
Files 714 714
Lines 96497 96497
==========================================
- Hits 70889 70886 -3
- Misses 24286 24289 +3
Partials 1322 1322
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kileys
approved these changes
Nov 22, 2022
Might be nice to try and test whether this is no longer an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that -PisRelease adds additional tasks which in the past have caused failures when run in parallel or with a prior daemon which is why we cautiously add --no-daemon and --no-parallel
Fixes #24266
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.