Gradle tasks to start playground locally (#23939) #23941
Conversation
|
lgtm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
|
||
| Start: | ||
|
|
||
| ```bash | ||
| cd beam | ||
| ./gradlew playground:backend:containers:router:dockerComposeLocalUp |
There was a problem hiding this comment.
Now that we are migrating to kubernetes, may we consider moving away from docker compose? An alternative is minikube. If you'd like a pair programming session to set this up, I'm more than willing.
There was a problem hiding this comment.
I have never been using Kubernetes in any way so it would take days to prepare for that session. Although I am too more than willing.
There may be benefits of minikube over local Docker, but this branch is more of a daily tool to us to develop against an undeployed backend. And the frontend does not care how the backend is started as long as it has a host and a port. We currently copy this configuration from one local branch to another. So it would just save time today if we had it in master.
One other reason to keep docker compose for awhile is that we already have it elsewhere, for instance in https://github.com/apache/beam/blob/master/playground/backend/containers/router/docker-compose.local.yml
There was a problem hiding this comment.
@pabloem LGTM understanding that this comment needs to be addressed in the future
|
lgtm thanks y'all |
* Gradle tasks to start playground locally (apache#23939) * Update task descriptions (apache#23939) * Add local backend running to README (apache#23939) * Clean up README (apache#23939)
This improvement was prepared by @vchunikhin and was kept in our local branch. We have been using it to develop frontend against unmerged backend branches.
I cannot test it fully because per Vlad it takes ~30 minutes on his machine to get all runners up, and mine is not powerful enough. Still this is useful if some runners and frontend are commented out.
I think this is better merged so it does not get outdated if living in our branch.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.