Include the GCP scope when creating a scoped credential token. #23410
Conversation
Include the GCP scope when creating a scoped credential token.
|
The Workflow run is cancelling this PR. It is an earlier duplicate of 2083803 run. |
|
R: @chamikaramj |
tvalentyn
changed the title
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Run Python 3.8 postcommit |
|
LGTM. Thanks. |
|
(also mention in the PR description that this scope is already included for Java SDK). |
Codecov Report
@@ Coverage Diff @@
## master #23410 +/- ##
==========================================
- Coverage 73.41% 73.40% -0.01%
==========================================
Files 718 718
Lines 95652 95652
==========================================
- Hits 70222 70216 -6
- Misses 24119 24125 +6
Partials 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -45,6 +45,7 @@ | |||
| _LOGGER = logging.getLogger(__name__) | |||
|
|
|||
| CLIENT_SCOPES = [ | |||
| 'https://www.googleapis.com/auth/cloud-platform', | |||
| 'https://www.googleapis.com/auth/bigquery', | |||
| 'https://www.googleapis.com/auth/cloud-platform', | |||
There was a problem hiding this comment.
Looks like the scope is already there, so this PR isn't actually doing anything.
There was a problem hiding this comment.
Yeah, you are right. This would not have any affect.
|
oops, my bad. |
It's recommended to use GCP scope in clients talking to GCP: https://cloud.google.com/compute/docs/access/service-accounts#accesscopesiam . This scope is used in Java SDK: https://github.com/apache/beam/blob/master/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/auth/GcpCredentialFactory.java#L47