Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated code in python sdk install #23231

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 14, 2022

A follow up of #23227. Noticed that the error reporting logic was not accurate either.

Fix outdated code in python sdk install

  • /sdks/common no longer exists. proto are in /model

  • Clean up findSupportedPython.groovy in PYTHON_SDK_ROOT

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Abacn Abacn marked this pull request as ready for review September 14, 2022 15:05
@Abacn Abacn marked this pull request as draft September 14, 2022 15:13
@Abacn
Copy link
Contributor Author

Abacn commented Sep 14, 2022

Seems like .pyi files were generated and packaged but .py files were not generated.

* /sdks/common no longer exists. proto are in /model

* Clean up findSupportedPython.groovy in PYTHON_SDK_ROOT
@Abacn Abacn changed the title Fix gen_proto detect generated file existence Fix outdated code in python sdk install Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #23231 (3733050) into master (9d9db56) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23231      +/-   ##
==========================================
- Coverage   73.58%   73.58%   -0.01%     
==========================================
  Files         716      716              
  Lines       95316    95327      +11     
==========================================
+ Hits        70140    70148       +8     
- Misses      23880    23883       +3     
  Partials     1296     1296              
Flag Coverage Δ
python 83.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../apache_beam/runners/interactive/dataproc/types.py 93.10% <0.00%> (-3.45%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 98.38% <0.00%> (-1.62%) ⬇️
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 87.24% <0.00%> (-0.61%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (-0.13%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 91.39% <0.00%> (+1.32%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn Abacn marked this pull request as ready for review September 14, 2022 20:12
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @yeandy for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@yeandy yeandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn
Copy link
Contributor Author

Abacn commented Sep 15, 2022

Thanks @yeandy
R: @tvalentyn

@github-actions
Copy link
Contributor

R: @tvalentyn for final approval

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn tvalentyn merged commit 065f3c3 into apache:master Sep 15, 2022
@Abacn Abacn deleted the protobuffollowup branch September 15, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants