-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outdated code in python sdk install #23231
Conversation
Seems like .pyi files were generated and packaged but .py files were not generated. |
* /sdks/common no longer exists. proto are in /model * Clean up findSupportedPython.groovy in PYTHON_SDK_ROOT
3745915
to
3733050
Compare
Codecov Report
@@ Coverage Diff @@
## master #23231 +/- ##
==========================================
- Coverage 73.58% 73.58% -0.01%
==========================================
Files 716 716
Lines 95316 95327 +11
==========================================
+ Hits 70140 70148 +8
- Misses 23880 23883 +3
Partials 1296 1296
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @yeandy for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @yeandy |
R: @tvalentyn for final approval |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
A follow up of #23227. Noticed that the error reporting logic was not accurate either.
Fix outdated code in python sdk install
/sdks/common no longer exists. proto are in /model
Clean up findSupportedPython.groovy in PYTHON_SDK_ROOT
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.