Use avro DataFileReader to read avro container files #23214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Run Java_PVR_Flink_Docker PreCommit |
|
Run Kotlin_Examples PreCommit |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
ping @iemejia |
iemejia
approved these changes
Sep 22, 2022
| throw new IllegalArgumentException("Unsupported codec: " + codec); | ||
| } | ||
| } | ||
| private final long numRecordsInBlock; |
| // Initialized in startReading. | ||
| private @Nullable AvroMetadata metadata; | ||
|
|
||
| private static class SeekableChannelInput implements SeekableInput { |
There was a problem hiding this comment.
A pity this one does not exist in Avro
| @@ -717,71 +678,25 @@ public synchronized AvroSource<T> getCurrentSource() { | |||
| // | |||
| // Postcondition: same as above, but for the new current (formerly next) block. | |||
| @Override | |||
| public boolean readNextBlock() throws IOException { | |||
| long startOfNextBlock; | |||
| synchronized (progressLock) { | |||
iemejia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #23213
This refactors AvroSource to use the standard DataFileReader from Avro. I don't really have the context around why a custom file parser was written in beam for this, but the code is so old I assume that DataFileReader couldn't properly support reading from arbitrary positions in a container file when it was written.
R: @iemejia (you were the last person other than myself to substantially change this class)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.