-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stripping of step name and replace with substring search #22415
Conversation
Run Python 3.9 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #22415 +/- ##
==========================================
- Coverage 74.17% 74.16% -0.01%
==========================================
Files 706 706
Lines 93190 93193 +3
==========================================
- Hits 69122 69116 -6
- Misses 22800 22809 +9
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Assigning reviewers. If you would like to opt out of this review, comment R: @TheNeuralBit for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anywhere we can test this?
I couldn't find any tests related to it. Any suggestions? |
Run Python 3.9 PostCommit |
How did you detect the issue? |
When I was trying to publish metrics to InfluxDB and BigQuery, the metrics were named like this https://ci-beam.apache.org/job/beam_Inference_Python_Benchmarks_Dataflow_PR/9/console |
Ah ok, thanks. I suppose this is just testing infrastructure so we don't need to be too picky. |
The strip methods strips out the characters mentioned in it. For the PytorchRunInference metrics, it strips out the p and outputs
ytorchruninfernece
instead.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.