-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split checkStyle from precommit into spotless job #22203
Conversation
retest this please |
Codecov Report
@@ Coverage Diff @@
## master #22203 +/- ##
==========================================
+ Coverage 74.22% 74.23% +0.01%
==========================================
Files 702 702
Lines 92937 92961 +24
==========================================
+ Hits 68985 69013 +28
+ Misses 22685 22681 -4
Partials 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Java PreCommit failed with "Failed to store cache entry for task ':sdks:java:io:jdbc:checkstyleTest'". Not sure whether it is related |
Run Java PreCommit |
Run Java_GCP_IO_Direct PreCommit |
precommits passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
A GH Action failed - almost certainly unrelated, but I'll rerun it to get green before merging |
Fixes #22202
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.