Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split checkStyle from precommit into spotless job #22203

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jul 8, 2022

Fixes #22202

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2022

retest this please

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #22203 (f13c3c1) into master (b9093fb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22203      +/-   ##
==========================================
+ Coverage   74.22%   74.23%   +0.01%     
==========================================
  Files         702      702              
  Lines       92937    92961      +24     
==========================================
+ Hits        68985    69013      +28     
+ Misses      22685    22681       -4     
  Partials     1267     1267              
Flag Coverage Δ
python 83.61% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/source_test_utils.py 88.01% <0.00%> (-1.39%) ⬇️
...ks/python/apache_beam/runners/worker/data_plane.py 87.57% <0.00%> (-0.57%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 94.76% <0.00%> (-0.21%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (-0.13%) ⬇️
...apache_beam/runners/dataflow/internal/apiclient.py 77.34% <0.00%> (-0.05%) ⬇️
...s/python/apache_beam/examples/snippets/snippets.py 76.70% <0.00%> (ø)
sdks/python/apache_beam/typehints/typehints.py 93.42% <0.00%> (+0.05%) ⬆️
sdks/python/apache_beam/dataframe/frames.py 95.41% <0.00%> (+0.14%) ⬆️
sdks/python/apache_beam/transforms/core.py 92.83% <0.00%> (+0.26%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9093fb...f13c3c1. Read the comment docs.

@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2022

Java PreCommit failed with "Failed to store cache entry for task ':sdks:java:io:jdbc:checkstyleTest'". Not sure whether it is related

@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2022

Run Java PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2022

Run Java_GCP_IO_Direct PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2022

precommits passed.
R: @damccorm

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@damccorm
Copy link
Contributor

A GH Action failed - almost certainly unrelated, but I'll rerun it to get green before merging

@damccorm damccorm merged commit 3d8db78 into apache:master Jul 11, 2022
konstantinurysov pushed a commit to akvelon/beam that referenced this pull request Jul 14, 2022
@Abacn Abacn deleted the splicheckstyle branch August 12, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Split checkStyle out from java PreCommit
2 participants