-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarification on Filter transform's input function to pydoc. #17704
Conversation
It was difficult to understand how to implement a function to pass to the Filter transform. I added a useful comment that was found in "https://beam.apache.org/documentation/transforms/python/elementwise/filter/".
Can one of the admins verify this patch? |
3 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #17704 +/- ##
==========================================
- Coverage 74.00% 73.99% -0.02%
==========================================
Files 695 695
Lines 91798 91798
==========================================
- Hits 67938 67922 -16
- Misses 22612 22628 +16
Partials 1248 1248
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
R: @tvalentyn |
Valentyn - I'm not sure who to add as reviewer, can you please take a look or help me find correct reviewer? |
Thank you! |
It was difficult to understand how to implement a function to pass to the Filter transform. I added a useful comment that was found in "https://beam.apache.org/documentation/transforms/python/elementwise/filter/".
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.