Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels for typescript PRs #17702

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented May 18, 2022

Since there are TypeScript developments actively submitted now it would be nice to have labels as other PRs.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented May 18, 2022

Can one of the admins verify this patch?

@Abacn
Copy link
Contributor Author

Abacn commented May 18, 2022

Tested on forked repo: Abacn#18

@Abacn Abacn marked this pull request as ready for review May 18, 2022 15:08
@Abacn
Copy link
Contributor Author

Abacn commented May 18, 2022

R: @robertwb

@github-actions github-actions bot added the build label May 18, 2022
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robertwb robertwb merged commit bac4e28 into apache:master May 20, 2022
@Abacn Abacn deleted the typescriptprlabel branch June 23, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants