[BEAM-14035] Convert BigQuery SchemaIO to SchemaTransform #17607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Hello @MarcoRob (cc: @angoenka ), Would anything in this PR lead to breaking beam_PreCommit_Java_Commit/22553 shows: |
|
No, actually it is a flaky test that is rarely failing and I am monitoring and validating in this PR (#17473). Please run again the Java PreCommit to get the checks passed. |
|
Run Java PreCommit |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check #17181 for more context on the code changes.
This PR, currently work-in-progress, closes BEAM-14035 by creating:
BigQuerySchemaTransformReadConfiguration- Configuration for reading from BigQuery.BigQuerySchemaTransformReadProvider- an implementation of TypedSchemaTransformProviderBigQuerySchemaTransformWriteConfiguration- Configuration for writing to BigQuery.BigQuerySchemaTransformWriteProvider- an implementation of TypedSchemaTransformProviderNote I created https://issues.apache.org/jira/browse/BEAM-14168 to handle additional BigQueryIO read and write parameters for a future PR. Additionally, I created https://issues.apache.org/jira/browse/BEAM-14260 to add additional integration tests in a future PR.
I would like to request to following to review this PR:
@angoenka
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.UpdateCHANGES.mdwith noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.