-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys #17319
[BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys #17319
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #17319 +/- ##
==========================================
+ Coverage 74.14% 74.18% +0.04%
==========================================
Files 676 684 +8
Lines 89008 89659 +651
==========================================
+ Hits 65992 66516 +524
- Misses 21869 21996 +127
Partials 1147 1147
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
R: @chamikaramj |
R: @pabloem |
LGTM |
Run PythonLint PreCommit |
Could this be merged? |
Yes, it can. @chamikaramj could you take another look? |
@chamikaramj @pabloem could one of you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Update the kafkaIO xlang integration test to publish and receive a null key instead of an empty byte string. This will validate the changes to KafkaIO Xlang that enables nullable keys and values
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.