Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10529] update KafkaIO Xlang integration test to publish and receive null keys #17319

Conversation

johnjcasey
Copy link
Contributor

Update the kafkaIO xlang integration test to publish and receive a null key instead of an empty byte string. This will validate the changes to KafkaIO Xlang that enables nullable keys and values


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Apr 8, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Apr 8, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 8, 2022

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #17319 (0b1199e) into master (70ff734) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17319      +/-   ##
==========================================
+ Coverage   74.14%   74.18%   +0.04%     
==========================================
  Files         676      684       +8     
  Lines       89008    89659     +651     
==========================================
+ Hits        65992    66516     +524     
- Misses      21869    21996     +127     
  Partials     1147     1147              
Flag Coverage Δ
python 83.64% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache_beam/runners/interactive/interactive_beam.py 77.81% <0.00%> (-3.28%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 90.24% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/coders/typecoders.py 92.40% <0.00%> (-2.27%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.84% <0.00%> (-1.41%) ⬇️
...ache_beam/runners/portability/expansion_service.py 91.83% <0.00%> (-1.35%) ⬇️
sdks/python/apache_beam/io/parquetio.py 95.16% <0.00%> (-0.93%) ⬇️
sdks/python/apache_beam/transforms/core.py 91.84% <0.00%> (-0.81%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.03% <0.00%> (-0.39%) ⬇️
.../apache_beam/io/gcp/datastore/v1new/datastoreio.py 86.16% <0.00%> (-0.29%) ⬇️
...he_beam/runners/interactive/sql/beam_sql_magics.py 49.51% <0.00%> (-0.24%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ff734...0b1199e. Read the comment docs.

@johnjcasey
Copy link
Contributor Author

R: @chamikaramj

@johnjcasey
Copy link
Contributor Author

R: @pabloem

@ahmedabu98
Copy link
Contributor

LGTM

@johnjcasey
Copy link
Contributor Author

Run PythonLint PreCommit

@aaltay
Copy link
Member

aaltay commented May 12, 2022

Could this be merged?

@johnjcasey
Copy link
Contributor Author

Yes, it can. @chamikaramj could you take another look?

@johnjcasey
Copy link
Contributor Author

@chamikaramj @pabloem could one of you take a look at this?

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@chamikaramj chamikaramj merged commit 4ed320c into apache:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants