Add tests for processing time continuation trigger #16840
Conversation
|
R: @scwhittle |
| import org.apache.beam.sdk.transforms.windowing.SlidingWindows; | ||
| import org.apache.beam.sdk.transforms.windowing.TimestampCombiner; | ||
| import org.apache.beam.sdk.transforms.windowing.Window; | ||
| import org.apache.beam.sdk.transforms.windowing.*; |
There was a problem hiding this comment.
Just checking about *. I haven't seen that elsewhere in Beam. Is it desirable, did allowing that change?
There was a problem hiding this comment.
It is not desirable. This is because I switched IntelliJ versions and it restored to defaults :-(
| * demonstrating that the watermark did not cause the output. No runner appears to support | ||
| * {@link TestStream} processing time correctly for this, so we do it with actually processing | ||
| * time delays, which must be kept small so the test suite does not take forever. There are also | ||
| * bugs in runners around {@code Window.configure()} behaving differently than {@code |
There was a problem hiding this comment.
should there be a JIRA for those bugs and referenced here?
There was a problem hiding this comment.
When I returned to this version of the test after writing the other version, I could not reproduce either issue. Using Window.configure() works, as does the processing time TestStream.
| @@ -186,6 +176,112 @@ public void testCombiningAccumulatingProcessingTime() throws Exception { | |||
| p.run(); | |||
| } | |||
|
|
|||
| /** | |||
| * Tests that data from a processing time trigger flows through subsequent GroupByKey | |||
| * transforms. To test this with TestStream, we check that it arrives in an early pane, | |||
There was a problem hiding this comment.
I don't see where you check it is in the early pane in the test. If it's there maybe a comment would help.
There was a problem hiding this comment.
In fact I had pushed this with it commented out. The PAssert itself only inspects early panes now.
kennknowles
force-pushed
the
aftersyncproctest
branch
2 times, most recently
from
f3f2a7a to
051d63d
Compare
|
Unfortunately Jenkins has been down/slow for nearly a week. Ideally I'll run some relevant suites locally and publish gradle scan in the meantime. |
|
Flink 1.13 success: https://gradle.com/s/53yqdmo6eo7tu (had to add |
kennknowles
force-pushed
the
aftersyncproctest
branch
from
051d63d to
cad8515
Compare
|
Jenkins woke up long enough to go green. |
I noticed there were no explicit tests for this configuration to ensure that a runner does allow output of a processing time trigger to flow through the pipeline.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.