Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12164]: Parses change streams fields as json / strings #16726

Merged
merged 2 commits into from
Feb 7, 2022
Merged

[BEAM-12164]: Parses change streams fields as json / strings #16726

merged 2 commits into from
Feb 7, 2022

Conversation

thiagotnunes
Copy link
Contributor

The backend is migrating from returning strings for certain fields to json. We need to change the parsing logic to accommodate for both until the migration is completed.

The backend is migrating from returning strings for certain fields to
json. We need to change the parsing logic to accommodate for both until
the migration is completed.
@thiagotnunes
Copy link
Contributor Author

retest this please

@thiagotnunes
Copy link
Contributor Author

Presubmit failures are unrelated to this PR

@thiagotnunes
Copy link
Contributor Author

R: @pabloem

@pabloem
Copy link
Member

pabloem commented Feb 4, 2022

Run Java PreCommit

@pabloem
Copy link
Member

pabloem commented Feb 4, 2022

this LGTM. Thanks @thiagotnunes

@pabloem
Copy link
Member

pabloem commented Feb 6, 2022

Run Java PreCommit

@thiagotnunes
Copy link
Contributor Author

Run Java PostCommit

@pabloem pabloem merged commit 7bafabc into apache:master Feb 7, 2022
@thiagotnunes thiagotnunes deleted the change-streams-json branch February 7, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants