[BEAM-13633] [Playground] Implement method to get a default example for each SDKs #16484
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -262,7 +262,7 @@ func (controller *playgroundController) GetPrecompiledObjects(ctx context.Contex | |
| // GetPrecompiledObjectCode returns the code of the specific example | ||
| func (controller *playgroundController) GetPrecompiledObjectCode(ctx context.Context, info *pb.GetPrecompiledObjectCodeRequest) (*pb.GetPrecompiledObjectCodeResponse, error) { | ||
| cd := cloud_bucket.New() | ||
| codeString, err := cd.GetPrecompiledObjectCode(ctx, info.GetCloudPath()) | ||
| if err != nil { | ||
| logger.Errorf("GetPrecompiledObjectCode(): cloud storage error: %s", err.Error()) | ||
| return nil, errors.InternalError("Error during getting Precompiled Object's code", "Error with cloud connection") | ||
|
|
@@ -294,3 +294,28 @@ func (controller *playgroundController) GetPrecompiledObjectLogs(ctx context.Con | |
| response := pb.GetPrecompiledObjectLogsResponse{Output: logs} | ||
| return &response, nil | ||
| } | ||
|
|
||
| // GetDefaultPrecompiledObject returns the default precompile object for sdk. | ||
| func (controller *playgroundController) GetDefaultPrecompiledObject(ctx context.Context, info *pb.GetDefaultPrecompiledObjectRequest) (*pb.GetDefaultPrecompiledObjectResponse, error) { | ||
| switch info.Sdk { | ||
| case pb.Sdk_SDK_UNSPECIFIED, pb.Sdk_SDK_SCIO: | ||
| logger.Errorf("GetDefaultPrecompiledObject(): unimplemented sdk: %s\n", info.Sdk) | ||
| return nil, errors.InvalidArgumentError("Error during preparing", "Sdk is not implemented yet: %s", info.Sdk.String()) | ||
| } | ||
|
|
||
| bucket := cloud_bucket.New() | ||
| precompiledObject, err := bucket.GetDefaultPrecompiledObject(ctx, controller.env.BeamSdkEnvs.DefaultExamplePath()) | ||
| if err != nil { | ||
| logger.Errorf("GetDefaultPrecompiledObject(): cloud storage error: %s", err.Error()) | ||
| return nil, errors.InternalError("Error during getting default Precompiled Object", "Error with cloud connection") | ||
| } | ||
|
|
||
| response := pb.GetDefaultPrecompiledObjectResponse{PrecompiledObject: &pb.PrecompiledObject{ | ||
| CloudPath: precompiledObject.CloudPath, | ||
| Name: precompiledObject.Name, | ||
| Description: precompiledObject.Description, | ||
| Type: precompiledObject.Type, | ||
| PipelineOptions: precompiledObject.PipelineOptions, | ||
| }} | ||
|
There was a problem hiding this comment. Shouldn't we return the code of the example as well? Or it will be requested from the frontend after receiving this response? There was a problem hiding this comment. Yes, this information will be enough for frontend. There was a problem hiding this comment. Could you please also add the |
||
| return &response, nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,5 +12,6 @@ | |
| "test_args": [ | ||
| "test", | ||
| "-v" | ||
| ], | ||
| "default_example": "SDK_GO/MinimalWordCount" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,5 +16,6 @@ | |
| "-cp", | ||
| "bin:", | ||
| "org.junit.runner.JUnitCore" | ||
| ], | ||
| "default_example": "SDK_JAVA/MinimalWordCount" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can include SCIO as a supported SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.