Update venv creation commands in release scripts. #16381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvalentyn
force-pushed
the
release_script_fixes
branch
from
9567fcf to
efe3f0c
Compare
… in test scripts to avoid flakes.
tvalentyn
force-pushed
the
release_script_fixes
branch
from
efe3f0c to
8289d42
Compare
tvalentyn
commented
Dec 29, 2021
| ``` | ||
|
|
||
| - Install, create and activate your [venv](https://docs.python.org/3/library/venv.html). | ||
| * Install, create and activate your [venv](https://docs.python.org/3/library/venv.html). |
There was a problem hiding this comment.
just reordered steps: create venv first, then install jupyterlab.
cc: @kevingg
Codecov Report
@@ Coverage Diff @@
## master #16381 +/- ##
==========================================
+ Coverage 74.63% 83.63% +8.99%
==========================================
Files 647 450 -197
Lines 81340 61817 -19523
==========================================
- Hits 60710 51698 -9012
+ Misses 19659 10119 -9540
+ Partials 971 0 -971 Continue to review full report at Codecov.
|
emilymye
approved these changes
Dec 29, 2021
tvalentyn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
wheelwhen we create venv (necessary follow up for [BEAM-13183] [BEAM-8152] Use venv instead of virtualenv to create Python environments in Gradle scripts. #15819), otherwise Beam fails to install from sources. BEAM-8954 would be a cleaner solution.)