Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13624] Run generatePythonRequirementsAll for pyarrow 6 #16000

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

TheNeuralBit
Copy link
Member

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit
Copy link
Member Author

This went very smoothly once I realized I just needed to install python-3.x-venv in the start-build-env.sh container. It looks like this is already handled in #15819

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #16000 (7be74ef) into master (6dc1b6f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16000      +/-   ##
==========================================
- Coverage   83.62%   83.62%   -0.01%     
==========================================
  Files         445      445              
  Lines       61371    61371              
==========================================
- Hits        51324    51322       -2     
- Misses      10047    10049       +2     
Impacted Files Coverage Δ
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (-2.24%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.00% <0.00%> (-1.00%) ⬇️
sdks/python/apache_beam/transforms/util.py 95.86% <0.00%> (-0.17%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️
...eam/runners/interactive/interactive_environment.py 91.72% <0.00%> (+0.34%) ⬆️
...runners/interactive/display/pcoll_visualization.py 86.36% <0.00%> (+0.50%) ⬆️
...pache_beam/runners/interactive/interactive_beam.py 76.58% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5656e26...7be74ef. Read the comment docs.

@@ -98,12 +99,13 @@ pandas==1.3.4
parameterized==0.7.5
pbr==5.7.0
Pillow==7.2.0
pkg_resources==0.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a bug..
see:
https://stackoverflow.com/questions/39577984/what-is-pkg-resources-0-0-0-in-output-of-pip-freeze-command

sounds like we might need to grep it out from the output for the script to work from the local env? or perhaps this will also go away with virtualenv->venv switch, although I don't fully understand when virtualenv was involved here. FWIW I don't get this line when I run this script.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I can add a patch to grep out pkg_resources and remove it from this PR.

As far as why this happened.. I don't think virtualenv was ever involved. It's notable that this only happened for py38, and not the other python versions. I'm not sure what that means though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you running it on mac?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I'm running on Debian (gLinux). But ./gradlew was actually executed inside the ./start-build-env.sh (ubuntu) container.

Added 99f489f to filter out pkg_resources

@tvalentyn tvalentyn merged commit 2335ec6 into apache:master Nov 17, 2021
@tvalentyn
Copy link
Contributor

tvalentyn commented Nov 17, 2021

PR number LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants