-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13624] Run generatePythonRequirementsAll
for pyarrow 6
#16000
Conversation
This went very smoothly once I realized I just needed to install |
Codecov Report
@@ Coverage Diff @@
## master #16000 +/- ##
==========================================
- Coverage 83.62% 83.62% -0.01%
==========================================
Files 445 445
Lines 61371 61371
==========================================
- Hits 51324 51322 -2
- Misses 10047 10049 +2
Continue to review full report at Codecov.
|
@@ -98,12 +99,13 @@ pandas==1.3.4 | |||
parameterized==0.7.5 | |||
pbr==5.7.0 | |||
Pillow==7.2.0 | |||
pkg_resources==0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a bug..
see:
https://stackoverflow.com/questions/39577984/what-is-pkg-resources-0-0-0-in-output-of-pip-freeze-command
sounds like we might need to grep it out from the output for the script to work from the local env? or perhaps this will also go away with virtualenv->venv switch, although I don't fully understand when virtualenv was involved here. FWIW I don't get this line when I run this script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I can add a patch to grep out pkg_resources and remove it from this PR.
As far as why this happened.. I don't think virtualenv was ever involved. It's notable that this only happened for py38, and not the other python versions. I'm not sure what that means though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you running it on mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I'm running on Debian (gLinux). But ./gradlew
was actually executed inside the ./start-build-env.sh
(ubuntu) container.
Added 99f489f to filter out pkg_resources
1979f26
to
7be74ef
Compare
PR number LGTM. |
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.