[BEAM-12513] Schemas and Coders #15632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @youngoli @riteshghorse @jrmccluskey |
jrmccluskey
approved these changes
Oct 1, 2021
| {{< /highlight >}} | ||
|
|
||
| {{< paragraph class="language-go" >}} | ||
| Overriding schema field names is useful for compatibility cross language transforms. |
There was a problem hiding this comment.
Is it worth elaborating on this point a bit or linking to documentation that does? This line being stand-alone in its current context doesn't convey much information.
There was a problem hiding this comment.
Elaborated a bit. Going to merge this in, things are generally easier to understand in rendered form, and it's easy enough to make spot fixes later.
dmitriikuzinepam
pushed a commit
to dmitriikuzinepam/beam
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation around Beam Schemas and coders to the BPG.
One aspect was less convenient than it should have been so I also expanded the functionality to unify the approach for both interface and non-interface struct types.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.