Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12445] Handle none bq_client #15194

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Conversation

angoenka
Copy link
Contributor

@angoenka angoenka commented Jul 20, 2021

Handling the case when google.cloud.bigquery import fails


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@angoenka
Copy link
Contributor Author

R: @pabloem
R: @chamikaramj
R: @ihji

@angoenka angoenka force-pushed the fix_bq_none_client branch from 50dfc7d to 6a95009 Compare July 20, 2021 18:09
@ihji
Copy link
Contributor

ihji commented Jul 20, 2021

Yeah, looks like the API also allows str argument: https://github.com/googleapis/python-bigquery/blob/v1.26.1/google/cloud/bigquery/client.py#L2605

Thanks, LGTM.

@angoenka
Copy link
Contributor Author

Thanks! Updated the test case. Will merge once the test pass.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #15194 (dac16b1) into master (c499c49) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15194      +/-   ##
==========================================
- Coverage   83.84%   83.83%   -0.02%     
==========================================
  Files         441      441              
  Lines       59706    59706              
==========================================
- Hits        50059    50052       -7     
- Misses       9647     9654       +7     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery_tools.py 87.33% <33.33%> (-0.15%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 92.68% <0.00%> (-2.44%) ⬇️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (-2.24%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 86.17% <0.00%> (-1.07%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.39% <0.00%> (-0.38%) ⬇️
sdks/python/apache_beam/transforms/util.py 95.81% <0.00%> (-0.17%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.85% <0.00%> (-0.16%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.70% <0.00%> (+0.37%) ⬆️
...runners/interactive/display/pcoll_visualization.py 85.78% <0.00%> (+0.52%) ⬆️
...pache_beam/runners/interactive/interactive_beam.py 76.59% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c499c49...dac16b1. Read the comment docs.

@angoenka angoenka force-pushed the fix_bq_none_client branch from 0e76047 to dac16b1 Compare July 21, 2021 06:39
@angoenka angoenka merged commit 46842eb into apache:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants