-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12422] Drop other optional logger libraries since Netty can detect which logger is available automatically #15113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15113 +/- ##
=======================================
Coverage 83.79% 83.80%
=======================================
Files 441 441
Lines 59530 59530
=======================================
+ Hits 49886 49891 +5
+ Misses 9644 9639 -5
Continue to review full report at Codecov.
|
Run Python PreCommit |
From your comment in https://issues.apache.org/jira/browse/BEAM-12422 Can you give me the Maven coordinates of the netty library you checked? I tried generating the dependency tree (https://gist.github.com/suztomo/5b906fa4850b4685081e870d45ae26b9) of |
https://mvnrepository.com/artifact/io.netty/netty-common/4.1.52.Final I looked at the source and it seems as though they try a bunch of loggers to find which one exists WDYT? |
…to detect a compatible logger internally
I decided to go with dropping the logging deps which will help clean-up our deps just a little. PTAL |
That makes sense. Netty checks the existence of the loggers. The vendored artifact does not need to include all the loggers. |
Run Java_Examples_Dataflow PreCommit |
Run Python PreCommit |
Also revert existing change that removed this dep and its relocation exclusions
See #15098 (comment) for details as to why this change over removing log4j-api
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.