[BEAM-9547] Add support for xs on DataFrame and Series #15078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15078 +/- ##
==========================================
+ Coverage 83.76% 83.78% +0.01%
==========================================
Files 439 439
Lines 59176 59211 +35
==========================================
+ Hits 49566 49607 +41
+ Misses 9610 9604 -6
Continue to review full report at Codecov.
|
|
R: @rohdesamuel |
rohdesamuel
reviewed
Jun 25, 2021
Comment on lines
879
to
887
| if axis in ('columns', 1): | ||
| return frame_base.DeferredFrame.wrap( | ||
| expressions.ComputedExpression( | ||
| 'xs', | ||
| lambda df: df.xs(key, axis=axis, **kwargs), [self._expr], | ||
| requires_partition_by=partitionings.Arbitrary(), | ||
| preserves_partition_by=partitionings.Arbitrary())) | ||
| elif axis not in ('index', 0): | ||
| raise ValueError( |
There was a problem hiding this comment.
Can you add some comments for these conditionals?
rohdesamuel
suggested changes
Jun 25, 2021
|
Run Python PreCommit |
1 similar comment
|
Run Python PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
xson DataFrame and Series instances.xsis really just a specialized filter on the index, which at first glance is trivially elementwise. However it is complicated by the fact that it raises aKeyErrorwhen the keyed value does not exist. In order to raise this error correctly (at execution time) in a distributed context, we need to know when we're processing the partition that should contain the key. In order to do this we wrap the key in a DeferredSeries and use Index partitioning to co-locate it, thus if the key is present in a partition, we know to raise an error if it doesn't exist in the target frame.ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.