Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12419] Deadline should be reset for each gRPC call. #14995

Merged
merged 1 commit into from
Jun 11, 2021
Merged

[BEAM-12419] Deadline should be reset for each gRPC call. #14995

merged 1 commit into from
Jun 11, 2021

Conversation

kw2542
Copy link
Contributor

@kw2542 kw2542 commented Jun 11, 2021

getState() in waitForTerminalState() is invoked multiple times and deadline should be reset each time since it is an absolute number.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

getState() in waitForTerminalState() is invoked multiple times and deadline should be reset each time since it is an absolute number.
@kw2542
Copy link
Contributor Author

kw2542 commented Jun 11, 2021

@apilloud Can you help take a look ?

@apilloud
Copy link
Member

Run Java Spark PortableValidatesRunner Batch

@apilloud
Copy link
Member

Run XVR_Spark PostCommit

@apilloud
Copy link
Member

Run XVR_Spark3 PostCommit

Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests I ran pass. This will need to be cherrypicked into the 2.31.0 release branch.

@kw2542
Copy link
Contributor Author

kw2542 commented Jun 11, 2021

Run Java Spark PortableValidatesRunner Batch

I did notice that Spark PVR Streaming tests have been broken into two tests in #14483 but not for Batch tests, are we going to apply the same improvement for batch mode tests ?

@apilloud
Copy link
Member

I'm not sure. That is probably a question for @ibzib

@ibzib
Copy link
Contributor

ibzib commented Jun 11, 2021

LGTM, thanks for fixing this.

I did notice that Spark PVR Streaming tests have been broken into two tests in #14483 but not for Batch tests, are we going to apply the same improvement for batch mode tests ?

I don't think there's much of a reason to separate them, since unlike the streaming tests both Spark versions consistently pass tests (while in streaming, Spark 3 is much less flaky than Spark 2, for unknown reasons).

@ibzib ibzib merged commit c0b8e65 into apache:master Jun 11, 2021
@kw2542 kw2542 deleted the BEAM-12419 branch July 14, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants