-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12411] Update Tensorflow to version 2.5.0 & grpcio to 1.34.0 #14888
Conversation
Run Portable_Python PreCommit |
Run PythonDocker PreCommit |
@aaltay It seems this requires to update also the grpcio version as a requisite too. |
You are right. Updated that too. |
Failing with:
Not sure how this change cause us to depend on keras-nightly. (@yifanmai - Do you have any idea?) @iemejia - Changing to 2.4.2 might be easier but that is not a released version yet. |
That is strange because I'd expect only tf-nightly to depend on keras-nightly. |
Run Python PreCommit |
It turns out tensorflow==2.5.0 depends on keras-nightly ~=2.5.0.dev. I can reproduce it in a clean virtual environment. I will file a bug. It was added here: tensorflow/tensorflow@d171d94 |
Can you please link the tensorflow issue for future reference. In the Java side we do not allow to include any SNAPSHOT dependency because of the lack of reproducibility. Is this ok to do on the python side? |
Run PythonDocker PreCommit |
I did not file a bug on their public issue tracker. The summary of the response was this was not intentional and it will be fixed in the next tensorflow release. If it helps, I can ask for a public bug for that. I do not think this is ok on python, and it was a bug. On the license side, I think we are ok. Because even the tool was failing to parse, there is a license and apparently we have a file on our repo to manually track licenses for packages if the tooling we use fails. |
Run PythonDocker PreCommit |
@iemejia - tests are passing now. Let me know if this looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, It is ok if the tensorflow team is already aware of it.
Thanks @aaltay . Can you please take care of cherry-picking this one for 2.31.0 since it is a security related upgrade. |
…rsion 2.5.0 & grpcio to 1.34.0
[BEAM-12411] Cherry-pick #14888: Update Tensorflow to version 2.5.0 & grpcio to 1.34.0
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.