-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10982] Add linux aarch64 wheel build support #14832
Conversation
👏 |
.github/workflows/build_wheels.yml
Outdated
{"os": "ubuntu-latest", "python": "cp36-* cp37-* cp38-*"}, | ||
{"os": "macos-latest", "python": "cp36-* cp37-* cp38-*"}, | ||
{"os": "windows-latest", "python": "cp36-* cp37-* cp38-*"}, | ||
{"os": "ubuntu-latest", "python": "cp36-* cp37-* cp38-* cp39-*"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have test suites for Py39 yet, however this may give impression that we already support it; it would add py39 wheels when we add Py3.9 test suites and officially support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have removed py39.
Thanks for this change, @odidev . Trying it out here: https://github.com/apache/beam/runs/2778415390?check_suite_focus=true |
Signed-off-by: odidev <[email protected]>
Thanks! |
This is excellent news ! So it seems with the recent dependency ugprades we are now fully aarch64. I can validate that on AWS Graviton if somewone here explains me how to install the equivalent of 'SNAPSHOT' or 'dev' dependencies on beam python |
Try https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-HowtoInstallanUnreleasedPythonSDKwithoutBuildingIt - and pip install the whl file. |
Thanks @tvalentyn I think there is a way to test this via emulation + docker images I saw this somewhere but I cannot remember now. I remember only the project they used https://github.com/dockcross/dockcross |
I saw some error messages because of wheels not available on other dependencies.
Curious I thought Beam did not use Apache Avro after the move to Python 3 or is it there only for backwards compatibility for users? |
We switched to fastavro as a default option, but there is a branch allowing to use avro-python3. We could delete that branch, I am not aware of any issues with fastavro on Python3. |
Added linux aarch64 wheel build support.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.