-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-11289] [Python] Integrate Google Cloud Recommendations AI functionality #14806
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14806 +/- ##
========================================
Coverage 83.77% 83.77%
========================================
Files 439 441 +2
Lines 59116 59371 +255
========================================
+ Hits 49523 49738 +215
- Misses 9593 9633 +40
Continue to review full report at Codecov.
|
Run Python 3.8 PostCommit |
@matthiasa4 - Is this ready for review? |
I do not know much about it. Why can't you grant these permissions? What do you need? |
So the pipeline tests call an API that sit in a test project (to which @pabloem has access) - last time we enabled the API, but since the API is returning |
That makes sense. Which project is this, is it apache-beam-testing? |
@aaltay yes, that's the one! |
I added you to the project. That should give you enough permissions to make the changes you need. Let me know if that does not work. |
@aaltay - getting the following message in the console at the moment: Also, is it fair to assume for the pipelines, the regular compute service accounts are used? Then I will be able to give this one the right permissions to call the API. |
Done. Give it a try. |
Run Python 3.8 PostCommit |
d4791e0
to
06d369d
Compare
Run Python 3.8 PostCommit |
ah so sorry about the delay. Looking... |
this LGTM : ) thanks @matthiasa4 - feel free to merge as you see fit! |
Integrate Google Cloud Recommendations AI functionality
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.