Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12050] Sickbay portable Flink tests of event time timers with TestStream #14333

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

kennknowles
Copy link
Member

These tests were incorrectly marked NeedsRunner instead of ValidatesRunner. They probably were never passing. In #14313 I fixed the annotation but did not run enough ValidatesRunner variations to catch the failure in https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/6184/


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK ULR Dataflow Flink Samza Spark Twister2
Go --- --- Build Status --- Build Status ---
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@kennknowles kennknowles requested a review from ihji March 25, 2021 02:44
@kennknowles kennknowles force-pushed the ParDoTest-flink-sickbay branch from dc5ae3c to d1f4808 Compare March 25, 2021 17:17
@kennknowles
Copy link
Member Author

Run Java Flink PortableValidatesRunner Streaming

@iemejia
Copy link
Member

iemejia commented Mar 26, 2021

Run Python_PVR_Flink PreCommit

@iemejia
Copy link
Member

iemejia commented Mar 26, 2021

Run Portable_Python PreCommit

Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit 776bf54 into apache:master Mar 26, 2021
@kennknowles kennknowles deleted the ParDoTest-flink-sickbay branch January 4, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants