Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParDoTest cases that should be ValidatesRunner #14313

Merged
merged 1 commit into from
Mar 24, 2021
Merged

ParDoTest cases that should be ValidatesRunner #14313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ public void processElement(ProcessContext cxt, @Element Long element) {
}

@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testMultiOutputChaining() {

PCollectionTuple filters =
Expand Down Expand Up @@ -1685,7 +1685,7 @@ public void testBundleFinalizationWithSideInputs() {
@RunWith(JUnit4.class)
public static class LifecycleTests extends SharedTestBase implements Serializable {
@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoWithErrorInStartBatch() {
List<Integer> inputs = Arrays.asList(3, -42, 666);

Expand All @@ -1697,7 +1697,7 @@ public void testParDoWithErrorInStartBatch() {
}

@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoWithErrorInProcessElement() {

List<Integer> inputs = Arrays.asList(3, -42, 666);
Expand All @@ -1710,7 +1710,7 @@ public void testParDoWithErrorInProcessElement() {
}

@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoWithErrorInFinishBatch() {

List<Integer> inputs = Arrays.asList(3, -42, 666);
Expand Down Expand Up @@ -1762,7 +1762,7 @@ public void finishBundle(FinishBundleContext c) {
@RunWith(JUnit4.class)
public static class TimestampTests extends SharedTestBase implements Serializable {
@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoOutputWithTimestamp() {

PCollection<Integer> input = pipeline.apply(Create.of(Arrays.asList(3, 42, 6)));
Expand All @@ -1783,7 +1783,7 @@ public void testParDoOutputWithTimestamp() {
}

@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoTaggedOutputWithTimestamp() {

PCollection<Integer> input = pipeline.apply(Create.of(Arrays.asList(3, 42, 6)));
Expand Down Expand Up @@ -3995,7 +3995,11 @@ public void onTimer() {}
}

@Test
@Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStreamWithProcessingTime.class})
@Category({
ValidatesRunner.class,
UsesTimersInParDo.class,
UsesTestStreamWithProcessingTime.class
})
public void testSimpleProcessingTimerTimer() throws Exception {
final String timerId = "foo";

Expand Down Expand Up @@ -4034,7 +4038,7 @@ public void onTimer(TimeDomain timeDomain, OutputReceiver<Integer> r) {
}

@Test
@Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
@Category({ValidatesRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
public void testEventTimeTimerUnbounded() throws Exception {
final String timerId = "foo";

Expand Down Expand Up @@ -4069,7 +4073,7 @@ public void onTimer(OutputReceiver<Integer> r) {
}

@Test
@Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
@Category({ValidatesRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
public void testEventTimeTimerAlignUnbounded() throws Exception {
final String timerId = "foo";

Expand Down Expand Up @@ -4117,7 +4121,7 @@ public void onTimer(
}

@Test
@Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
@Category({ValidatesRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
public void testEventTimeTimerAlignAfterGcTimeUnbounded() throws Exception {
final String timerId = "foo";

Expand Down