Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9196] Update testcontainers to 1.15.1 #13530

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Dec 11, 2020

R: @piotr-szuberski @aromanenko-dev

@aromanenko-dev
Copy link
Contributor

Run Java KafkaIO Performance Test

@aromanenko-dev
Copy link
Contributor

Run Java HadoopFormatIO Performance Test

@@ -448,7 +448,7 @@ class BeamModulePlugin implements Plugin<Project> {
def slf4j_version = "1.7.30"
def spark_version = "2.4.7"
def spotbugs_version = "4.0.6"
def testcontainers_version = "1.15.0-rc2"
def testcontainers_version = "1.15.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using yesterday's 1.15.1 :)

Suggested change
def testcontainers_version = "1.15.0"
def testcontainers_version = "1.15.1"

@iemejia iemejia force-pushed the BEAM-9196-testcontainers branch from 275f276 to dc7ecb9 Compare December 14, 2020 08:32
@iemejia iemejia changed the title [BEAM-9196] Update testcontainers to 1.15.0 [BEAM-9196] Update testcontainers to 1.15.1 Dec 14, 2020
@iemejia
Copy link
Member Author

iemejia commented Dec 14, 2020

Thanks for the pointer @bsideup . Updated now

@pjotrekk
Copy link

LGTM

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@aromanenko-dev aromanenko-dev merged commit fc42781 into apache:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants