-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10137] Add KinesisIO for cross-language usage with python wrapper #12297
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8b1ce67
[BEAM-10138][BEAM-10137] Create kinesis expansion-service
63a2bfc
[BEAM-10138] Add Cross-language KinesisWrite external transform
2e42af1
[BEAM-10137] Generify KinesisIO.Read
7fc3ddd
[BEAM-10137] Add Cross-language KinesisIO.Read external transform reg…
71bdd30
[BEAM-10137][BEAM-10138] Add Python wrapper for Cross-language Java K…
e31d470
[BEAM-10137][BEAM-10138] Add integration tests for Python wrapper for…
ab8735a
Split the tests for localstack and real aws
602e2f9
Use dict instead of list[kv]
ed5637a
replace assert with warning when future timestamp provided
c0ea87e
Change to checker Nullable
6ac3fc5
Move enums to the end of file
f25f237
Add Mapping instead of kv list
5d87990
Change seconds to millis
3ea7b96
Improve params validation
4125094
Add more params to the test pipeline
33cf246
Change deprecated knownBuilders to knownBuilderInstances
16747d1
Improve boolean expression
a9345ef
run spotless
42c62b1
Fix linter
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* License); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an AS IS BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
apply plugin: 'org.apache.beam.module' | ||
apply plugin: 'application' | ||
mainClassName = "org.apache.beam.sdk.expansion.service.ExpansionService" | ||
|
||
applyJavaNature( | ||
enableChecker: true, | ||
automaticModuleName: 'org.apache.beam.sdk.io.kinesis.expansion.service', | ||
exportJavadoc: false, | ||
validateShadowJar: false, | ||
shadowClosure: {}, | ||
) | ||
|
||
description = "Apache Beam :: SDKs :: Java :: IO :: Kinesis :: Expansion Service" | ||
ext.summary = "Expansion service serving KinesisIO" | ||
|
||
dependencies { | ||
compile project(":sdks:java:expansion-service") | ||
compile project(":sdks:java:io:kinesis") | ||
runtime library.java.slf4j_jdk14 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukecwik I suggested that Piotr make Read generic so that we can add
Read<byte[]> readData()
naturally, but now I'm wondering if this is a bad idea since it changes our Public API. Does this have a risk of breaking users?It looks like at least the way the method is used in our tests (
p.apply(KinesisIO.read())
) is unaffected.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prob. this is OK as long as the change is backwards compatible for user pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The worst thing I can imagine is that a user will get a raw type warning if he used it like
KinesisIO.Read read = KinesisIO.read();
. Some users could have some checkers that would turn it into an error though. I don't know how much common such tools are in the Java development in projects using Beam.PCollection<KinesisRecord> = pipeline.apply(KinesisIO.read()...));
doesn't change so I think it's ok.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine if it doesn't require a user code change.