Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python precommit timeout to 3hrs #10234

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Bump python precommit timeout to 3hrs #10234

merged 1 commit into from
Nov 27, 2019

Conversation

aaltay
Copy link
Member

@aaltay aaltay commented Nov 27, 2019

Follow up to #10121

Regular version of the precommits are timing out. Not the pytest versions. Apply the same timeout to both places.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Follow up to #10121

Regular version of the precommits are timing out. Not the pytest versions. Apply the same timeout to both places.
@aaltay aaltay requested review from udim and Ardagan November 27, 2019 18:38
@aaltay aaltay merged commit 5bd9d1d into master Nov 27, 2019
@aaltay aaltay deleted the aaltay-patch-3 branch November 27, 2019 19:01
@udim udim mentioned this pull request Nov 27, 2019
3 tasks
@udim
Copy link
Member

udim commented Nov 27, 2019

run seed job

@aaltay
Copy link
Member Author

aaltay commented Dec 4, 2019

Both @udim and @robertwb mentioned that this change does not help. Because there are some tests that got stuck/took a long time(?) and even with extended timeout tests still timeout. In the good case these tests do already fit in 2 hrs.

We can rollback this change based on the above observation. More important question would be, how are we going to identify which tests got stuck. So far we seem to be only able to see this issue in Jenkins environment and we have many hundreds of unit tests, running in 8 difference configurations.

@aaltay
Copy link
Member Author

aaltay commented Dec 6, 2019

I still see : "21:11:51 Build timed out (after 120 minutes). Marking the build as aborted." I do not believe this timeout is actually doing what we expect. : https://builds.apache.org/job/beam_PreCommit_Python_Commit/10218/console

@yifanzou is this the right way to set timeout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants