[BEAM-8840][BEAM-3713] Remove setup_requires, tests_require from setup.py #10227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing race conditions in setuptools when trying to install pytest_runner under sdks/python/.eggs.
|
I just shot you an email on the list. I'm not sure that this is going to fix it. I already removed this from my PR and I'm still getting errors with .egg directories: https://scans.gradle.com/s/oinh5xpaly3dk/failure?openFailures=WzFd&openStackTraces=WzZd#top=1 edited to correct PR link |
aaltay
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
LGTM. Thank you.
This seems to be the right move anyway based on the deprecation notice here (https://pypi.org/project/pytest-runner/). And hopefully it will also fix the test issues here.
|
We should still get rid of setup_requires, but this just might not be the complete solution. |
|
Python precommit failed on I'll remove the |
udim
changed the title
udim
changed the title
3 tasks
3 tasks
3 tasks
nika-qubit
pushed a commit
to nika-qubit/beam
that referenced
this pull request
Dec 9, 2019
1. Added [interactive] as extras for py36 and py37 gcp tests so they will be executed at least once during the pre-commit. The [interactive] dependencies were removed after PR apache#10227 deprecating the old setup config, thus not triggering any pcoll_visualization tests since then. 2. Fixed the Setup routine of pcoll_visualization_tests so that global environment is always fresh no matter how the unit tests modify its states. The bug was caused by wrong execution paths instructed by undeterministic tests execution sequence. Somehow, the unittest's patch utility fails to patch _to_element_list some times in multi-threading. Using InteractiveRunner when building pipelines to lazily initialize a cache manager for those scenarios.
tysonjh
pushed a commit
to tysonjh/beam
that referenced
this pull request
Dec 18, 2019
1. Added [interactive] as extras for py36 and py37 gcp tests so they will be executed at least once during the pre-commit. The [interactive] dependencies were removed after PR apache#10227 deprecating the old setup config, thus not triggering any pcoll_visualization tests since then. 2. Fixed the Setup routine of pcoll_visualization_tests so that global environment is always fresh no matter how the unit tests modify its states. The bug was caused by wrong execution paths instructed by undeterministic tests execution sequence. Somehow, the unittest's patch utility fails to patch _to_element_list some times in multi-threading. Using InteractiveRunner when building pipelines to lazily initialize a cache manager for those scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing race conditions in setuptools when trying to install
pytest_runner under sdks/python/.eggs.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.