Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prism] Resolve endless timer test org.apache.beam.sdk.transforms.ParDoTest$TimerTests.testEventTimeTimerOrderingWithCreate #32222

Closed
Tracked by #29650
lostluck opened this issue Aug 16, 2024 · 0 comments · Fixed by #33270
Closed
Tracked by #29650

[prism] Resolve endless timer test org.apache.beam.sdk.transforms.ParDoTest$TimerTests.testEventTimeTimerOrderingWithCreate #32222

lostluck opened this issue Aug 16, 2024 · 0 comments · Fixed by #33270
Assignees
@lostluck
Labels
go prism
Milestone
2.62.0 Release

Comments

@lostluck
Copy link
Contributor

lostluck commented Aug 16, 2024 •
edited
Loading 

TEST=org.apache.beam.sdk.transforms.ParDoTest\$TimerTests.testEventTimeTimerOrderingWithCreate
./gradlew :runners:portability:java:ulrLoopbackValidatesRunnerTests -PjobEndpoint=localhost:8073 --tests="$TEST"

Doesn't currently terminate, which means there's a subtle ordering requirement that prism isn't respecting somehow, leading to infinite looping.

The way the test expects to execute needs to be described here, so we can determine what's going wrong, and why it doesn't terminate.
This was referenced Aug 16, 2024
Open
Closed
@lostluck lostluck self-assigned this Aug 16, 2024
@lostluck lostluck modified the milestone: 2.59.0 Release Aug 20, 2024
lostluck added a commit to lostluck/beam that referenced this issue Dec 3, 2024
@lostluck
[apache#32222] Actually maintain the heap invariant for timers.
bd2271b
@lostluck lostluck mentioned this issue Dec 3, 2024
Merged
3 tasks
lostluck added a commit that referenced this issue Dec 4, 2024
@lostluck
[#32222] Actually maintain the heap invariant for timers. (#33270)
2e43e29
@github-actions github-actions bot added this to the 2.62.0 Release milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostluck lostluck

Labels
go prism
Projects
None yet
Milestone
2.62.0 Release
Development

Successfully merging a pull request may close this issue.

[#32222] Actually maintain the heap invariant for timers. lostluck/beam
1 participant
@lostluck