Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Replace JacksonFactory references with GsonFactory #32130

Closed
1 of 17 tasks
damccorm opened this issue Aug 9, 2024 · 4 comments · Fixed by #32158
Closed
1 of 17 tasks

[Task]: Replace JacksonFactory references with GsonFactory #32130

damccorm opened this issue Aug 9, 2024 · 4 comments · Fixed by #32158
Assignees
@cutiepie-10
Labels
good first issue java P2 task
Milestone
2.59.0 Release

Comments

@damccorm
Copy link
Contributor

damccorm commented Aug 9, 2024

What needs to happen?

Per https://cloud.google.com/java/docs/reference/google-http-client/latest/com.google.api.client.json.jackson2.JacksonFactory this class has been deprecated. In theory it should just be a 1:1 switch

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@cutiepie-10
Copy link
Contributor

Hi @damccorm,
I would like to contribute to this issue. Though, I would like some help as this is my first issue.

@cutiepie-10
Copy link
Contributor

.take-issue

cutiepie-10 pushed a commit to cutiepie-10/beam that referenced this issue Aug 11, 2024
@dragonHead1001001
[Task]: Replace JacksonFactory references with GsonFactory apache#32130
be64a84
This was referenced Aug 11, 2024
Closed
Closed
@damccorm
Copy link
Contributor Author

Thanks for picking this up! I left a few minor comments in #32148

@cutiepie-10 cutiepie-10 mentioned this issue Aug 12, 2024
Merged
@cutiepie-10
Copy link
Contributor

Hi @damccorm ,
I have opened a new pull request by mistake please look into the changes.
I need some help regarding this issue.

damccorm pushed a commit that referenced this issue Aug 19, 2024
@cutiepie-10 @dragonHead1001001
Replacing Jackson Factory with Gson Factory and further code updation (…
8c0fbf7 
…#32158)

* [Task]: Replace JacksonFactory references with GsonFactory #32130

* Fixing minor issues due to the replacement of JacksonFcatory with GsonFactory and further updation

* Correcting gradle-wrapper.properties

* Removing date and time from gradle-properties

* Correcting Format in files

---------

Co-authored-by: dragonHead1001001 <[email protected]>
@github-actions github-actions bot added this to the 2.59.0 Release milestone Aug 19, 2024
reeba212 pushed a commit to reeba212/beam that referenced this issue Dec 4, 2024
@cutiepie-10 @dragonHead1001001 @reeba212
Replacing Jackson Factory with Gson Factory and further code updation (…
7f54118 
…apache#32158)

* [Task]: Replace JacksonFactory references with GsonFactory apache#32130

* Fixing minor issues due to the replacement of JacksonFcatory with GsonFactory and further updation

* Correcting gradle-wrapper.properties

* Removing date and time from gradle-properties

* Correcting Format in files

---------

Co-authored-by: dragonHead1001001 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cutiepie-10 cutiepie-10

Labels
good first issue java P2 task
Projects
None yet
Milestone
2.59.0 Release
Development

Successfully merging a pull request may close this issue.

Replacing Jackson Factory with Gson Factory and further code updation cutiepie-10/beam
2 participants
@damccorm @cutiepie-10