Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: [beam-sdks-java-core]: Create method SerializableComparator.comparing(SerialiableFunction) #30257

Closed
1 of 16 tasks
je-ik opened this issue Feb 8, 2024 · 6 comments · Fixed by #32074
Closed
1 of 16 tasks

[Feature Request]: [beam-sdks-java-core]: Create method SerializableComparator.comparing(SerialiableFunction) #30257

je-ik opened this issue Feb 8, 2024 · 6 comments · Fixed by #32074
Assignees
@Mr-Magnificent @kirupha2000
Labels
good first issue java new feature P3
Milestone
2.59.0 Release

Comments

@je-ik
Copy link
Contributor

je-ik commented Feb 8, 2024

What would you like to happen?

Analogous to Comparator.comparing().

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Gupta-Suruchi
Copy link

Hi @je-ik, I'm currently working on Java projects & would love to contribute in this code. Can you please assign this issue to me?

@je-ik
Copy link
Contributor Author

je-ik commented Feb 13, 2024

Hi, you can do that yourself, see here, section "Fix an open issue".

@shubamwalia shubamwalia mentioned this issue Mar 8, 2024
Closed
3 tasks
@Mr-Magnificent
Copy link

.take-issue

@imvtsl
Copy link
Contributor

imvtsl commented Aug 1, 2024

.take-issue

@imvtsl imvtsl removed their assignment Aug 3, 2024
@kirupha2000
Copy link
Contributor

.take-issue

@kirupha2000
Copy link
Contributor

Hi @je-ik , first time contributor here! I've gone through the contributing guidelines and raised a pull request for the issue here - #32074. Please take a look and let me know if I'm missing something. Thanks in advance!

@kirupha2000 kirupha2000 mentioned this issue Aug 4, 2024
Merged
kirupha2000 added a commit to kirupha2000/beam that referenced this issue Aug 13, 2024
@kirupha2000
GitHub issue apache#30257
b0f2683 
Adds a static comparing method to the SerializableComparator interface
je-ik added a commit that referenced this issue Aug 14, 2024
@je-ik
Merge pull request #32074: Fixes GitHub issue #30257
7a4850d
@github-actions github-actions bot added this to the 2.59.0 Release milestone Aug 14, 2024
reeba212 pushed a commit to reeba212/beam that referenced this issue Dec 4, 2024
@kirupha2000 @reeba212
GitHub issue apache#30257
b47a187 
Adds a static comparing method to the SerializableComparator interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mr-Magnificent Mr-Magnificent

@kirupha2000 kirupha2000

Labels
good first issue java new feature P3
Projects
None yet
Milestone
2.59.0 Release
Development

Successfully merging a pull request may close this issue.

Fixes GitHub issue #30257 kirupha2000/beam
5 participants
@je-ik @Mr-Magnificent @imvtsl @kirupha2000 @Gupta-Suruchi