Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Failing Test]: beam_PostCommit_XVR_Direct perma-red. #28972

Closed
16 tasks
chamikaramj opened this issue Oct 12, 2023 · 4 comments · Fixed by #30568
Closed
16 tasks

[Failing Test]: beam_PostCommit_XVR_Direct perma-red. #28972

chamikaramj opened this issue Oct 12, 2023 · 4 comments · Fixed by #30568

Comments

@chamikaramj
Copy link
Contributor

What happened?

Seems like Go x-lang integration tests (for example, DebeziumIO, JDBCIO) are flaky.

For example,

https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/4702/consoleFull

10:26:17 2023/10/10 17:25:26 🐳 Terminating container: 82fa13ab9230
10:26:17 containers.go:100: error terminating container: Error response from daemon: No such container: 82fa13ab92303fc01cc1db52f2cf67f1c9a7666cf3611cdd0bce58936fc8d232
10:26:17 --- FAIL: TestDebeziumIO_BasicRead (144.27s)
10:26:17 FAIL

We should probably convert this tests to use Prism runner to be stable.

Issue Failure

Failure: Test is flaky

Issue Priority

Priority: 2 (backlog / disabled test but we think the product is healthy)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@lostluck
Copy link
Contributor

lostluck commented Feb 6, 2024

At this point it appears to be hard failing for a few Python 3.11 related issues.

https://github.com/apache/beam/actions/runs/7803720204/job/21284093581

https://github.com/apache/beam/actions/workflows/beam_PostCommit_XVR_Direct.yml?query=is%3Afailure

:sdks:python:test-suites:direct:xlang:validatesCrossLanguageRunnerPythonUsingSql

 File "/runner/_work/beam/beam/build/gradleenv/1922375555/lib/python3.11/site-packages/apache_beam/transforms/trigger.py", line 1376, in process_elements
    if input_watermark > window.end + self.allowed_lateness:
                         ^^^^^^^^^^
AttributeError: 'bytes' object has no attribute 'end'

@lostluck lostluck changed the title [Failing Test]: Go tests are flaky in beam_PostCommit_XVR_Direct [Failing Test]: beam_PostCommit_XVR_Direct perma-red. Feb 6, 2024
@lostluck lostluck added permared and removed flake labels Feb 6, 2024
@Abacn
Copy link
Contributor

Abacn commented Mar 6, 2024

This is a regression in Beam 2.53.0. Unfortunately GHA logs expires in 3 months. From now one only knows the regression happens between Nov 8, 2023 (last successful run and https://github.com/apache/beam/actions/runs/7018120946) - Dec 8, 2023 #2111 (first run see this issue and still has log)

@Abacn
Copy link
Contributor

Abacn commented Mar 6, 2024

CC: @robertwb

@Abacn
Copy link
Contributor

Abacn commented Mar 6, 2024

For some reason the window in WindowedValue decoded here

windowed_key_value = coder_impl.decode_from_stream(input_stream, True)

is not a tuple of window objects, but a tuple of bytes e.g. (b"\x80\x00\x00\x00\x00\x00'\x10\x90N",), (b'\x80\x00\x00\x00\x00\x00N \x90N',), etc


The WIndowedValueCoder with BytesCoder as its window coder is constructed here:

return cls(*components)

so it's using the information from proto to construct the coder.

@robertwb robertwb self-assigned this Mar 8, 2024
@github-actions github-actions bot added this to the 2.56.0 Release milestone Mar 8, 2024
robertwb added a commit to robertwb/incubator-beam that referenced this issue Mar 8, 2024
This was exposed by apache#28972 when the set of "known" coders was
inadvertently reduced.
hjtran pushed a commit to hjtran/beam that referenced this issue Apr 4, 2024
This was exposed by apache#28972 when the set of "known" coders was
inadvertently reduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants