-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task][Go SDK]: Dataflow Go PostCommits timing out #23422
Comments
Specifically, we could reduce the number of pipelines by consolidating them into a single pipeline for the specific area. The we have Dataflow filtering out the individual pipelines where the consolidated ones are used instead. This may require some test prefix renaming to simplify. beam/sdks/go/test/integration/integration.go Line 222 in a393efa
eg. All the State Pipelines could be consolidated into a single pipeline: And the State tests renamed and prefixed, eg. TestStateAPI_MapState Allowing the other runners to filter out TestConsolidated.* and Dataflow to filter out TestStateAPI* (along with the indication that it's covered by the consolidated test) And similarly across common areas in the integration tests. |
Seen this before and was transient #23311 |
Yeah, transient or not, it's a flake, which means it interrupts velocity. Since our apache-beam-testing project for Dataflow is a shared resource and we have only so many simultaneous job slots, I'd rather get the post commit back down under an hour. |
Looks like this has stabilized. |
What needs to happen?
Currently the postcommits are failing. We need to investigate where the time is being spent and if possible, either parallelized it better (WRT beam project Dataflow quotas), or consolidate some test pipelines into single jobs (better handling quota), or reduce the number of specific tests we're running against dataflow post commits (eg. remove low signal tests).
As a stop gap, double the 2.5h timeout to 5h.
Issue Priority
Priority: 1
Issue Component
Component: sdk-go
The text was updated successfully, but these errors were encountered: