Skip to content

Commit

Permalink
ParDoTest cases that should be ValidatesRunner
Browse files Browse the repository at this point in the history
  • Loading branch information
kennknowles committed Mar 23, 2021
1 parent 67dc5fe commit cdc36bf
Showing 1 changed file with 14 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ public void processElement(ProcessContext cxt, @Element Long element) {
}

@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testMultiOutputChaining() {

PCollectionTuple filters =
Expand Down Expand Up @@ -1685,7 +1685,7 @@ public void testBundleFinalizationWithSideInputs() {
@RunWith(JUnit4.class)
public static class LifecycleTests extends SharedTestBase implements Serializable {
@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoWithErrorInStartBatch() {
List<Integer> inputs = Arrays.asList(3, -42, 666);

Expand All @@ -1697,7 +1697,7 @@ public void testParDoWithErrorInStartBatch() {
}

@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoWithErrorInProcessElement() {

List<Integer> inputs = Arrays.asList(3, -42, 666);
Expand All @@ -1710,7 +1710,7 @@ public void testParDoWithErrorInProcessElement() {
}

@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoWithErrorInFinishBatch() {

List<Integer> inputs = Arrays.asList(3, -42, 666);
Expand Down Expand Up @@ -1762,7 +1762,7 @@ public void finishBundle(FinishBundleContext c) {
@RunWith(JUnit4.class)
public static class TimestampTests extends SharedTestBase implements Serializable {
@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoOutputWithTimestamp() {

PCollection<Integer> input = pipeline.apply(Create.of(Arrays.asList(3, 42, 6)));
Expand All @@ -1783,7 +1783,7 @@ public void testParDoOutputWithTimestamp() {
}

@Test
@Category(NeedsRunner.class)
@Category(ValidatesRunner.class)
public void testParDoTaggedOutputWithTimestamp() {

PCollection<Integer> input = pipeline.apply(Create.of(Arrays.asList(3, 42, 6)));
Expand Down Expand Up @@ -3995,7 +3995,11 @@ public void onTimer() {}
}

@Test
@Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStreamWithProcessingTime.class})
@Category({
ValidatesRunner.class,
UsesTimersInParDo.class,
UsesTestStreamWithProcessingTime.class
})
public void testSimpleProcessingTimerTimer() throws Exception {
final String timerId = "foo";

Expand Down Expand Up @@ -4034,7 +4038,7 @@ public void onTimer(TimeDomain timeDomain, OutputReceiver<Integer> r) {
}

@Test
@Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
@Category({ValidatesRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
public void testEventTimeTimerUnbounded() throws Exception {
final String timerId = "foo";

Expand Down Expand Up @@ -4069,7 +4073,7 @@ public void onTimer(OutputReceiver<Integer> r) {
}

@Test
@Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
@Category({ValidatesRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
public void testEventTimeTimerAlignUnbounded() throws Exception {
final String timerId = "foo";

Expand Down Expand Up @@ -4117,7 +4121,7 @@ public void onTimer(
}

@Test
@Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
@Category({ValidatesRunner.class, UsesTimersInParDo.class, UsesTestStream.class})
public void testEventTimeTimerAlignAfterGcTimeUnbounded() throws Exception {
final String timerId = "foo";

Expand Down

0 comments on commit cdc36bf

Please sign in to comment.