Also move dataframe comp tests to preCommitPyCoverage

apache · Jan 23, 2023 · 9fc7ef0 · 9fc7ef0
1 parent 010d1d3
commit 9fc7ef0
Showing 1 changed file with 16 additions and 21 deletions.
diff --git a/sdks/python/test-suites/tox/py38/build.gradle b/sdks/python/test-suites/tox/py38/build.gradle
@@ -36,8 +36,6 @@ testPy38Cython.mustRunAfter testPython38, testPy38CloudCoverage
 
 // TODO(BEAM-12000): Move tasks that aren't specific to 3.8 to Py 3.9.
 def posargs = project.findProperty("posargs") ?: ""
-def runDataframeTests = (posargs == "" || posargs.contains("dataframe"))
-logger.info('Running dataframes tests: ' + runDataframeTests)
 
 // PyCoverage Precommit runs test suites that evaluate test coverage and compatibility of
 // particular dependencies. It is exercised on a single Python version.
@@ -86,29 +84,26 @@ toxTask "testPy38pyarrow-9", "py38-pyarrow-9", "${posargs}"
 test.dependsOn "testPy38pyarrow-9"
 preCommitPyCoverage.dependsOn "testPy38pyarrow-9"
 
-// Dataframe tests won't get auto-filtered by path since they explicitly only run on the dataframes directory in tox.ini
-if (runDataframeTests) {
-  // Create a test task for each minor version of pandas
-  toxTask "testPy38pandas-11", "py38-pandas-11", "${posargs}"
-  test.dependsOn "testPy38pandas-11"
-  preCommitPy38.dependsOn "testPy38pandas-11"
+// Create a test task for each minor version of pandas
+toxTask "testPy38pandas-11", "py38-pandas-11", "${posargs}"
+test.dependsOn "testPy38pandas-11"
+preCommitPyCoverage.dependsOn "testPy38pandas-11"
 
-  toxTask "testPy38pandas-12", "py38-pandas-12", "${posargs}"
-  test.dependsOn "testPy38pandas-12"
-  preCommitPy38.dependsOn "testPy38pandas-12"
+toxTask "testPy38pandas-12", "py38-pandas-12", "${posargs}"
+test.dependsOn "testPy38pandas-12"
+preCommitPyCoverage.dependsOn "testPy38pandas-12"
 
-  toxTask "testPy38pandas-13", "py38-pandas-13", "${posargs}"
-  test.dependsOn "testPy38pandas-13"
-  preCommitPy38.dependsOn "testPy38pandas-13"
+toxTask "testPy38pandas-13", "py38-pandas-13", "${posargs}"
+test.dependsOn "testPy38pandas-13"
+preCommitPyCoverage.dependsOn "testPy38pandas-13"
 
-  toxTask "testPy38pandas-14", "py38-pandas-14", "${posargs}"
-  test.dependsOn "testPy38pandas-14"
-  preCommitPy38.dependsOn "testPy38pandas-14"
+toxTask "testPy38pandas-14", "py38-pandas-14", "${posargs}"
+test.dependsOn "testPy38pandas-14"
+preCommitPyCoverage.dependsOn "testPy38pandas-14"
 
-  toxTask "testPy38pandas-15", "py38-pandas-15", "${posargs}"
-  test.dependsOn "testPy38pandas-15"
-  preCommitPy38.dependsOn "testPy38pandas-15"
-}
+toxTask "testPy38pandas-15", "py38-pandas-15", "${posargs}"
+test.dependsOn "testPy38pandas-15"
+preCommitPyCoverage.dependsOn "testPy38pandas-15"
 
 // Create a test task for each minor version of pytorch
 toxTask "testPy38pytorch-19", "py38-pytorch-19", "${posargs}"