Skip to content

Commit

Permalink
remove duplicate test, add doc
Browse files Browse the repository at this point in the history
  • Loading branch information
riteshghorse committed Apr 15, 2024
1 parent d6930db commit 7be053f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def __init__(
Args:
entity_id (str): entity name for the entity associated with the features.
The `entity_id` is used to extract the entity value from the input row.
feature_store_yaml_path (str): The path to a YAML configuration file for
the Feast feature store.
feature_names: A list of feature names to be retrieved from the online
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,23 +87,6 @@ def test_feast_enrichment_bad_feature_service_name(self):
res = test_pipeline.run()
res.wait_until_finish()

def test_feast_enrichment_bad_yaml_path(self):
"""Test raising an error when wrong yaml file is passed."""
requests = [
beam.Row(user_id=1, product_id=1),
]

with self.assertRaises(RuntimeError):
handler = FeastFeatureStoreEnrichmentHandler(
entity_id='user_id',
feature_store_yaml_path='gs://bad_path',
feature_service_name="bad_name",
)
test_pipeline = beam.Pipeline()
_ = (test_pipeline | beam.Create(requests) | Enrichment(handler))
res = test_pipeline.run()
res.wait_until_finish()


if __name__ == '__main__':
unittest.main()

0 comments on commit 7be053f

Please sign in to comment.