adjust warning log

apache · Oct 4, 2024 · 6cecc3c · 6cecc3c
1 parent 07fea59
commit 6cecc3c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/StringSetData.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/StringSetData.java
@@ -132,8 +132,8 @@ private static long addUntilCapacity(
         // check capacity both before insert and after insert one, so the warning only emit once.
         if (currentSize > STRING_SET_SIZE_LIMIT) {
           LOG.warn(
-              "StringSetData reaches capacity. Current size: {}, last element size: {}. Further "
-                  + "incoming elements will be dropped.",
+              "StringSet metrics reaches capacity. Further incoming elements won't be recorded."
+                  + " Current size: {}, last element size: {}.",
               currentSize,
               string.length());
           break;

diff --git a/sdks/python/apache_beam/metrics/cells.py b/sdks/python/apache_beam/metrics/cells.py
@@ -606,8 +606,8 @@ def add_until_capacity(
         current_size += len(string)
         if current_size > cls._STRING_SET_SIZE_LIMIT:
           _LOGGER.warning(
-              "StringSetData reaches capacity. Current size: %d, last element "
-              "size: %d. Further incoming elements will be dropped.",
+              "StringSet metrics reaches capacity. Further incoming elements "
+              "won't be recorded. Current size: %d, last element size: %d.",
               current_size,
               len(string))
           break