Add an SdkHarnessOption that controls whether logging is redirected t…

…hrough the FnApi logging service. Redirection through the FnApi is enabled by default.
apache · Dec 19, 2024 · 6a3274f · 6a3274f
1 parent 85450f4
commit 6a3274f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java
@@ -110,12 +110,12 @@ enum LogLevel {
 
   void setLogMdc(boolean value);
 
-   /** This option controls whether logging will be redirected through the logging service. */
-  @Description("Controls whether logging will be redirected through the logging service.")
+   /** This option controls whether logging will be redirected through the FnApi. */
+  @Description("Controls whether logging will be redirected through the FnApi.")
   @Default.Boolean(true)
-  boolean getEnableLoggingService();
+  boolean getEnableLogViaFnApi();
 
-  void setEnableLoggingService(boolean enableLoggingService);
+  void setEnableLogViaFnApi(boolean enableLogViaFnApi);
 
   /**
    * Size (in MB) of each grouping table used to pre-combine elements. Larger values may reduce the

diff --git a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/logging/LoggingClientFactory.java b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/logging/LoggingClientFactory.java
@@ -23,7 +23,7 @@ public static LoggingClient createAndStart(
       PipelineOptions options,
       Endpoints.ApiServiceDescriptor apiServiceDescriptor,
       Function<Endpoints.ApiServiceDescriptor, ManagedChannel> channelFactory) {
-    if (options.as(SdkHarnessOptions.class).getEnableLoggingService()) {
+    if (options.as(SdkHarnessOptions.class).getEnableLogViaFnApi()) {
       return BeamFnLoggingClient.createAndStart(options, apiServiceDescriptor, channelFactory);
     } else {
       return new NoOpLoggingClient();