fix failing tests

apache · Mar 26, 2020 · 52695aa · 52695aa
1 parent f478de7
commit 52695aa
Show file tree

Hide file tree

Showing 6 changed files with 639 additions and 674 deletions.
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/CoGroup.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/CoGroup.java
@@ -632,8 +632,7 @@ private void crossProductHelper(
       if (atBottom) {
         // Bottom of recursive call, so output the row we've accumulated.
         Row row =
-            Row.withSchema(getOutputSchema())
-                .attachValues(Lists.newArrayList(accumulatedRows));
+            Row.withSchema(getOutputSchema()).attachValues(Lists.newArrayList(accumulatedRows));
         o.output(row);
       } else {
         crossProduct(tagIndex + 1, accumulatedRows, iterables, o);

diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
@@ -368,11 +368,6 @@ public ByteCodeAppender appender(final Target implementationTarget) {
                             ElementMatchers.named("attachValues")
                                 .and(ElementMatchers.takesArguments(Object[].class)))
                         .getOnly()),
-                MethodInvocation.invoke(
-                    new ForLoadedType(Row.Builder.class)
-                        .getDeclaredMethods()
-                        .filter(ElementMatchers.named("build"))
-                        .getOnly()),
                 MethodReturn.REFERENCE);
         size = size.aggregate(attachToRow.apply(methodVisitor, implementationContext));
         return new Size(size.getMaximalSize(), localVariables.getTotalNumVariables());