Skip to content

Commit

Permalink
Merge pull request #23759 from riteshghorse/import-fix
Browse files Browse the repository at this point in the history
[Go SDK] Fix lints in recent import
  • Loading branch information
TheNeuralBit authored Oct 20, 2022
2 parents c557b97 + 3e8bc10 commit 3d055da
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func NewExpansionServiceRunner(jarPath, servicePort string) (*ExpansionServiceRu
return &ExpansionServiceRunner{execPath: jarPath, servicePort: servicePort, serviceCommand: serviceCommand}, nil
}

// NewExpansionServiceRunner builds an ExpansionServiceRunner struct for a given python module and
// NewPyExpansionServiceRunner builds an ExpansionServiceRunner struct for a given python module and
// Beam version and returns a pointer to it. Passing an empty string as servicePort will request an
// open port to be assigned to the service.
func NewPyExpansionServiceRunner(pythonExec, module, servicePort string) (*ExpansionServiceRunner, error) {
Expand Down
3 changes: 2 additions & 1 deletion sdks/go/pkg/beam/transforms/xlang/python/external.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ import (
)

const (
pythonCallableUrn = "beam:logical_type:python_callable:v1"
pythonCallableUrn = "beam:logical_type:python_callable:v1"
// ExpansionServiceModule is the module containing the python expansion service for python external transforms.
ExpansionServiceModule = "apache_beam.runners.portability.expansion_service_main"
)

Expand Down

0 comments on commit 3d055da

Please sign in to comment.