-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-10328: [C++] Vendor fast_float number parsing library #8494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
|
After:
|
Do we need to unvendor double-conversion? |
pitrou
force-pushed
the
ARROW-10328-fast-float
branch
from
October 20, 2020 14:35
077bec5
to
b493d7d
Compare
No, we still use it for the other way round (float to string). |
pitrou
force-pushed
the
ARROW-10328-fast-float
branch
from
October 20, 2020 18:41
b493d7d
to
077869d
Compare
This library is 2x to 3x faster for parsing strings to binary floating-point numbers.
pitrou
force-pushed
the
ARROW-10328-fast-float
branch
from
October 21, 2020 12:26
077869d
to
244d7af
Compare
pitrou
commented
Oct 21, 2020
bkietz
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice speedup, I'll wait to merge until attribution has been resolved
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This library is 2x to 3x faster for parsing strings to binary floating-point numbers. Closes apache#8494 from pitrou/ARROW-10328-fast-float Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
3 tasks
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is 2x to 3x faster for parsing strings to binary floating-point numbers.