Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [C++] Bump Google Benchmark version #44939

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Dec 4, 2024

No description provided.

@pitrou
Copy link
Member Author

pitrou commented Dec 4, 2024

The Google benchmark configure step has failed on Windows + MSVC:

[56/606] Performing configure step for 'gbenchmark_ep'
FAILED: gbenchmark_ep-prefix/src/gbenchmark_ep-stamp/gbenchmark_ep-configure D:/a/arrow/arrow/build/cpp/gbenchmark_ep-prefix/src/gbenchmark_ep-stamp/gbenchmark_ep-configure 
C:\Windows\system32\cmd.exe /C "cd /D D:\a\arrow\arrow\build\cpp\gbenchmark_ep-prefix\src\gbenchmark_ep-build && "C:\Program Files\CMake\bin\cmake.exe" -P D:/a/arrow/arrow/build/cpp/gbenchmark_ep-prefix/src/gbenchmark_ep-stamp/gbenchmark_ep-configure-DEBUG.cmake && "C:\Program Files\CMake\bin\cmake.exe" -E touch D:/a/arrow/arrow/build/cpp/gbenchmark_ep-prefix/src/gbenchmark_ep-stamp/gbenchmark_ep-configure"
CMake Error at D:/a/arrow/arrow/build/cpp/gbenchmark_ep-prefix/src/gbenchmark_ep-stamp/gbenchmark_ep-configure-DEBUG.cmake:37 (message):
  Command failed: 1

   'C:/Program Files/CMake/bin/cmake.exe' '-DCMAKE_C_COMPILER=C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe' '-DCMAKE_CXX_COMPILER=C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe' '-DCMAKE_AR=C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/lib.exe' '-DBUILD_SHARED_LIBS=OFF' '-DBUILD_STATIC_LIBS=ON' '-DBUILD_TESTING=OFF' '-DCMAKE_BUILD_TYPE=DEBUG' '-DCMAKE_CXX_FLAGS= /D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING' '-DCMAKE_CXX_FLAGS_DEBUG=/Z7 /Ob0 /Od /RTC1  -MDd' '-DCMAKE_CXX_FLAGS_MISIZEREL=/O1 /Ob1 /DNDEBUG -MD' '-DCMAKE_CXX_FLAGS_RELEASE=/O2 /Ob2 /DNDEBUG -MD' '-DCMAKE_CXX_FLAGS_RELWITHDEBINFO=/Z7 /O2 /Ob1 /DNDEBUG -MD' '-DCMAKE_CXX_STANDARD=17' '-DCMAKE_C_FLAGS=' '-DCMAKE_C_FLAGS_DEBUG=/Z7 /Ob0 /Od /RTC1  -MDd' '-DCMAKE_C_FLAGS_MISIZEREL=/O1 /Ob1 /DNDEBUG -MD' '-DCMAKE_C_FLAGS_RELEASE=/O2 /Ob2 /DNDEBUG -MD' '-DCMAKE_C_FLAGS_RELWITHDEBINFO=/Z7 /O2 /Ob1 /DNDEBUG -MD' '-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=' '-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=' '-DCMAKE_INSTALL_LIBDIR=lib' '-DCMAKE_OSX_SYSROOT=' '-DCMAKE_VERBOSE_MAKEFILE=OFF' '-DCMAKE_C_COMPILER_LAUNCHER=C:/Program Files/Git/usr/bin/ccache.exe' '-DCMAKE_CXX_COMPILER_LAUNCHER=C:/Program Files/Git/usr/bin/ccache.exe' '-DCMAKE_INSTALL_PREFIX=D:/a/arrow/arrow/build/cpp/gbenchmark_ep/src/gbenchmark_ep-install' '-DBENCHMARK_ENABLE_TESTING=OFF' '-DCMAKE_CXX_FLAGS= /D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING' '-GNinja' '-S' 'D:/a/arrow/arrow/build/cpp/gbenchmark_ep-prefix/src/gbenchmark_ep' '-B' 'D:/a/arrow/arrow/build/cpp/gbenchmark_ep-prefix/src/gbenchmark_ep-build'

  See also

    D:/a/arrow/arrow/build/cpp/gbenchmark_ep-prefix/src/gbenchmark_ep-stamp/gbenchmark_ep-configure-*.log


-- stdout output is:
-- The CXX compiler identification is MSVC 19.29.30157.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: C:/Program Files/Git/mingw64/bin/git.exe (found version "2.47.0.windows.1")
-- Google Benchmark version: v1.9.1, normalized to 1.9.1
-- Looking for shm_open in rt
-- Looking for shm_open in rt - not found
-- Performing Test HAVE_CXX_FLAG_WX
-- Performing Test HAVE_CXX_FLAG_WX - Success
-- Compiling and running to test HAVE_STD_REGEX
-- Performing Test HAVE_STD_REGEX -- failed to compile
-- Compiling and running to test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Compiling and running to test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- failed to compile
-- Configuring incomplete, errors occurred!

-- stderr output is:
CMake Error at CMakeLists.txt:316 (message):
  Failed to determine the source files for the regular expression backend

@pitrou pitrou changed the title MINOR: [C++] Bump GBenchmark version MINOR: [C++] Bump Google Benchmark version Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant