Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44831: [CI] Build Java for integration tests from arrow-java #44932

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Dec 4, 2024

Rationale for this change

We moved java/ in apache/arrow to apache/arrow-java. We should use apache/arrow-java to integration tests.

What changes are included in this PR?

  • Remove java/
  • Use apache/arrow-java for integration test

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@lidavidm
Copy link
Member Author

lidavidm commented Dec 4, 2024

We can't actually merge this until we finish deleting the rest of the existing Java code here.

@lidavidm
Copy link
Member Author

lidavidm commented Dec 4, 2024

It seems integration works...

@lidavidm lidavidm marked this pull request as ready for review December 4, 2024 10:31
@lidavidm
Copy link
Member Author

lidavidm commented Dec 4, 2024

We...may not want to merge this as-is, but it passes tests!

This was referenced Dec 5, 2024
@lidavidm
Copy link
Member Author

lidavidm commented Dec 5, 2024

Updated, I think the macOS issue is not related.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 8ac434f into apache:main Dec 5, 2024
15 of 16 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Dec 5, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 5, 2024
@lidavidm lidavidm deleted the gh-44831 branch December 5, 2024 07:56
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8ac434f.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Remove java/ [Java][CI] Use apache/arrow-java for integration test
2 participants